This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
fix for usage of baseURI which doesn't work in IE11 #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added unit tests (this is the first time I've used typescript, so feel free to suggest a refactor) |
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
document.baseURIdoesn't exist in IE and causes errors. This attempts to get it and then falls back to looking at the base tag if present.Fixes #1561 and #1034 as well as an issue where prefetch would also fail in IE as it also depends on baseURI.
Opening in draft because:
Before submitting the PR, please make sure you do the following
Tests
npm testand lint the project withnpm run lint